Re: [PATCH] t9100: fix breakage when SHELL_PATH is not /bin/sh

On Mon, Feb 08, 2016 at 11:43:19AM -0800, Junio C Hamano wrote:

quoted

But then what is write_script buying us?

The correct way to write a script for a specific interpreter is to
give a second parameter to write_script, i.e.

		write_script exec.sh /bin/sh </dev/null &&

and the answer to the question is "it will save us one line".

At the cost of a useless "cat" invocation, though. :)

The version in 'master' that does

                echo "#!/bin/sh" >exec.sh &&
                chmod +x exec.sh &&

should be equivalent, so dropping that hunk from the patch is the
right resolution perhaps?

Yeah, but I still don't understand why the original did not work on
Windows, once all the other hunks from bcb11f1 are applied.

-Peff