Thread (20 messages) flat view 20 messages, 3 authors, 2016-06-15

Re: [PATCH v4 06/15] submodule--helper: die on config error when cloning module

From: Patrick Steinhardt <hidden>
Date: 2016-06-15 23:08:09

On Tue, Feb 02, 2016 at 01:45:50PM -0500, Eric Sunshine wrote:
On Tue, Feb 2, 2016 at 6:51 AM, Patrick Steinhardt [off-list ref] wrote:
quoted
When setting the 'core.worktree' option for a newly cloned
submodule we ignore the return value of `git_config_set_in_file`.
As this leaves the submodule in an inconsistent state, we instaed
we want to inform the user that something has gone wrong by
s/instaed/instead/

Also, there are too many "we"s, so dropping one would be a good idea:
either "we instead" or "instead we".
quoted
printing an error and aborting the program.

Signed-off-by: Patrick Steinhardt <redacted>
Thanks, fixed now.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help