Thread (14 messages) flat view 14 messages, 3 authors, 2016-06-15

Re: [PATCH v1] config: add '--sources' option to print the source of a config value

From: Jeff King <hidden>
Date: 2016-06-15 23:08:09

On Mon, Feb 08, 2016 at 12:25:58PM +0100, Sebastian Schuberth wrote:
On 2/5/2016 14:58, Jeff King wrote:
quoted
Yeah, I agree it's unlikely. And the output is already ambiguous, as the
first field could be a blob (though I guess the caller knows if they
passed "--blob" or not). If we really wanted an unambiguous output, we
could have something like "file:...", "blob:...", etc. But that's a bit
less readable for humans, and I don't think solves any real-world
problems.

So I think it would be OK to use "<command line>" here, as long as the
token is documented.
Thinking about it again, I actually do like Peff's prefix solution better.
It would solve the real-world problem that my proposed "<command line>"
marker could in fact be a file name.
I'm OK with that direction, but I think it will need some more
infrastructure in the config code (right now we just set "name" to some
string without recording its type). It probably would not be too hard to
add, though.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help