Thread (35 messages) 35 messages, 3 authors, 2016-06-15

Re: [PATCH v3 6/6] worktree add: switch to worktree version 1

From: Max Kirillov <hidden>
Date: 2016-06-15 23:08:03

On Mon, Feb 01, 2016 at 01:05:05PM +0700, Duy Nguyen wrote:
On Mon, Feb 1, 2016 at 12:33 PM, Max Kirillov [off-list ref] wrote:
quoted
1. For submodules (which must be left per-worktree) this
approach is not going to work, because you don't know all
variables in advance. You could scan the config file and
match those actual keys which are there with patterns.
Hmm.. we could keep existing submodule.* per-worktree. New variables
are per-worktree by default, unless you do "git config --repo" in
git-submodule.sh. Am I missing something?
Submodules in new worktree should be not initialized, and as
far as I understand this means that submodule variables
should be removed from common config.

I used test from
http://article.gmane.org/gmane.comp.version-control.git/266621
to verify expectations for submodules.
quoted
2. This migrates variables to the default (or current?)
worktree, what about others existing?
In v0, $C/config contains all shared variables, once we move these
shared vars to $C/common/config, they will be visible to all other
worktrees. Or do you replicate per-worktree vars in $C/config to all
worktrees ?
If would make sense for some variables definitely. For
example, the submodule related variables.

-- 
Max
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help