Thread (1 message) 1 message, 1 author, 2016-06-15

Re: AW: [PATCH 1/2] stash--helper: implement "git stash--helper"

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:08:03

Michael Blume [off-list ref] writes:
Maybe this isn't important given that it looks like the patch is going
to be rewritten, but I have

stash.c:43:18: warning: incompatible pointer types assigning to 'const
char *const *' from 'const char *'; take the address with &
[-Wincompatible-pointer-types]
                write_tree.env = prefix;
The way posted patch tries to use the .env field when using the
run-command API is totally bogus and this compilation error is a
manifestation of that.

But the good news is that this should become irrelevant when the
patch is done by using internal calls ;-).
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help