Thread (14 messages) 14 messages, 2 authors, 2016-06-15

Re: [PATCH v7 01/11] dir: free untracked cache when removing it

flat view

From: Stefan Beller <hidden>
Date: 2016-06-15 23:07:53

On Sun, Jan 24, 2016 at 7:28 AM, Christian Couder
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Christian Couder <redacted>
---
 builtin/update-index.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/builtin/update-index.c b/builtin/update-index.c
index 7431938..a6fff87 100644
--- a/builtin/update-index.c
+++ b/builtin/update-index.c
@@ -1123,6 +1123,7 @@ int cmd_update_index(int argc, const char **argv, const char *prefix)
                add_untracked_ident(the_index.untracked);
                the_index.cache_changed |= UNTRACKED_CHANGED;
        } else if (!untracked_cache && the_index.untracked) {
+               free_untracked_cache(the_index.untracked);
Do we need to free its members, too? (Or is it empty enough here,
that there are no memleaks in there? If this were the case a hint in
the commit message would be helpful)
                the_index.untracked = NULL;
                the_index.cache_changed |= UNTRACKED_CHANGED;
        }
--
2.7.0.181.gd7ef666.dirty
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help