Re: [PATCH v3 04/15] ref-filter: introduce struct used_atom

On Fri, Jan 22, 2016 at 12:34 AM, Eric Sunshine [off-list ref] wrote:

On Tuesday, January 5, 2016, Karthik Nayak [off-list ref] wrote:

quoted

Introduce the 'used_atom' structure to replace the existing
implementation of 'used_atom' (which is a list of atoms). This helps
us parse atoms beforehand and store required details into the
'used_atom' for future usage.

Helped-by: Eric Sunshine [off-list ref]
Signed-off-by: Karthik Nayak <redacted>
---

diff --git a/ref-filter.c b/ref-filter.c

@@ -17,7 +17,7 @@
 typedef enum { FIELD_STR, FIELD_ULONG, FIELD_TIME } cmp_type;

 /*
- * An atom is a valid field atom listed above, possibly prefixed with
+ * An atom is a valid field atom listed below, possibly prefixed with

This particular change should be in patch 3/15 which moved this comment block.

(Yes, it's true that this will make the patch something other than
"pure code movement", but this change keeps the moved block logically
consistent and that it's an appropriate thing to do -- plus it's quite
minor.)

Will squeeze that in. Like you said it's too small so it would make
sense to bundle it
within 3/15.

-- 
Regards,
Karthik Nayak