Re: [PATCH 18/19] mingw: skip a couple of git-svn tests that cannot pass on Windows
From: Junio C Hamano <hidden>
Date: 2016-06-15 23:07:53
Johannes Schindelin [off-list ref] writes:
Some of the tests expect that executable bits can be toggled, others expect that paths are POSIX paths (but when they come through git.exe, they are converted into Windows paths and necessarily differ), yet others expect symbolic links to be available.
These skip the tests that cannot possibly pass in their entirety by protecting them with prerequisites, which feels the right thing to do. The "executable bits" ones would need to become !POSIXPERM, and symlink ones !SYMLINKS, though. Thanks.
quoted hunk
This lets t9100-git-svn-basic.sh and t9130-git-svn-authors-file.sh pass in Git for Windows' SDK. Signed-off-by: Johannes Schindelin <redacted> --- t/t9100-git-svn-basic.sh | 15 +++++++-------- t/t9130-git-svn-authors-file.sh | 2 +- 2 files changed, 8 insertions(+), 9 deletions(-)diff --git a/t/t9100-git-svn-basic.sh b/t/t9100-git-svn-basic.sh index bca7ec8..8c74ffa 100755 --- a/t/t9100-git-svn-basic.sh +++ b/t/t9100-git-svn-basic.sh@@ -127,7 +127,7 @@ test_expect_success "$name" ' name='remove executable bit from a file' -test_expect_success "$name" ' +test_expect_success !MINGW "$name" ' rm -f "$GIT_DIR"/index && git checkout -f -b mybranch5 ${remotes_git_svn} && chmod -x exec.sh &&@@ -140,7 +140,7 @@ test_expect_success "$name" ' name='add executable bit back file' -test_expect_success "$name" ' +test_expect_success !MINGW "$name" ' chmod +x exec.sh && git update-index exec.sh && git commit -m "$name" &&@@ -151,7 +151,7 @@ test_expect_success "$name" ' name='executable file becomes a symlink to file' -test_expect_success "$name" ' +test_expect_success !MINGW "$name" ' rm exec.sh && ln -s file exec.sh && git update-index exec.sh &&@@ -163,8 +163,7 @@ test_expect_success "$name" ' name='new symlink is added to a file that was also just made executable' -test_expect_success "$name" ' - chmod +x file && +test_expect_success !MINGW "$name" ' ln -s file exec-2.sh && git update-index --add file exec-2.sh && git commit -m "$name" &&@@ -175,7 +174,7 @@ test_expect_success "$name" ' test -h "$SVN_TREE"/exec-2.sh' name='modify a symlink to become a file' -test_expect_success "$name" ' +test_expect_success !MINGW "$name" ' echo git help >help && rm exec-2.sh && cp help exec-2.sh &&@@ -191,7 +190,7 @@ test_expect_success "$name" ' name="commit with UTF-8 message: locale: $GIT_SVN_LC_ALL" LC_ALL="$GIT_SVN_LC_ALL" export LC_ALL -test_expect_success UTF8 "$name" " +test_expect_success !MINGW,UTF8 "$name" " echo '# hello' >> exec-2.sh && git update-index exec-2.sh && git commit -m '???????' &&@@ -224,7 +223,7 @@ tree d667270a1f7b109f5eb3aaea21ede14b56bfdd6e tree 8f51f74cf0163afc9ad68a4b1537288c4558b5a4 EOF -test_expect_success "$name" "test_cmp a expected" +test_expect_success !MINGW "$name" "test_cmp a expected" test_expect_success 'exit if remote refs are ambigious' " git config --add svn-remote.svn.fetch \diff --git a/t/t9130-git-svn-authors-file.sh b/t/t9130-git-svn-authors-file.sh index d306b77..4126481 100755 --- a/t/t9130-git-svn-authors-file.sh +++ b/t/t9130-git-svn-authors-file.sh@@ -91,7 +91,7 @@ test_expect_success 'fetch continues after authors-file is fixed' ' ) ' -test_expect_success 'fresh clone with svn.authors-file in config' ' +test_expect_success !MINGW 'fresh clone with svn.authors-file in config' ' ( rm -r "$GIT_DIR" && test x = x"$(git config svn.authorsfile)" &&