Re: [PATCH 0/4] ls-remote: introduce symref argument
From: Jeff King <hidden>
Date: 2016-06-15 23:07:47
On Sun, Jan 17, 2016 at 12:03:58PM +0100, Thomas Gummerer wrote:
quoted
I thought it might be nice for any porcelain which tries to wrap `ls-remote`, make some decision based on the capabilities, and then invoke another plumbing command. But I guess that is probably slightly crazy, and nobody is doing it. Something like `ls-remote --symrefs` probably would be a better place to start.Turns out adding this is pretty simple. The first two patches are documentation, which I noticed when reading up about the command. Patch three is a cleanup patch, which makes ls-remote use the parse-options api instead of the hand-rolled option parser. Patch four is actually adding the option. Thomas Gummerer (4): ls-remote: document --quiet option ls-remote: fix synopsis ls-remote: use parse-options api ls-remote: add support for showing symrefs Documentation/git-ls-remote.txt | 12 +++++- builtin/ls-remote.c | 90 +++++++++++++++++------------------------ t/t5512-ls-remote.sh | 20 +++++++++ 3 files changed, 68 insertions(+), 54 deletions(-)
Thanks for working on this. One of my favorite things about open source is when I realize I'm too lazy/busy to work on something, and then it magically appears in my inbox. :) This looks like a good start. I left a few comments on the specific patches. -Peff