Re: [PATCH v4 00/21] Peace with CRLF
From: Jeff King <hidden>
Date: 2016-06-15 23:07:47
On Thu, Jan 14, 2016 at 03:58:15PM -0800, Junio C Hamano wrote:
This is a reroll of http://thread.gmane.org/gmane.comp.version-control.git/282614 which is a continuation to $gmane/275735, which is filed in the archive under another mailing list: http://thread.gmane.org/gmane.comp.version-control.msysgit/21773
I just read through the whole thing and made a few comments. Please feel free to ignore my "how about this on top" suggestions if you don't like them, or just don't want to deal with them. Patches I didn't respond to all looked good to me. There are a few "iffy" conversions where we take unconstrained input and there's no "usual" quoting mechanism available (you mentioned the one in "grep", and I pointed out a few more). I hate to break backwards-compatibility in any way, but I think in all of those cases that we are much more likely to be helping the user than hurting them. So I think it's a net benefit in all of the cases. -Peff