Thread (33 messages) flat view 33 messages, 5 authors, 2016-06-15

Re: [PATCH v4 3/4] Provide a dirname() function when NO_LIBGEN_H=YesPlease

From: Johannes Schindelin <hidden>
Date: 2016-06-15 23:07:43

Hi Ramsay,

On Wed, 13 Jan 2016, Ramsay Jones wrote:
Also, when compiling on Cygwin with NO_LIBGEN_H, I need to
include the following here:

#undef basename

in order to suppress approx 230 warnings about the redefinition
of the basename macro.

(I suppose that should go in the previous commit. dunno)
I think this is an incorrect use of NO_LIBGEN_H (because Cygwin obviously
has it), but in any case, it is a completely independent issue from
fixing/testing basename()/dirname(), so your #undef basename should be in
a completely separate commit, methinks.

Ciao,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help