Re: [PATCH 2/2] contrib/git-candidate: Add README

From
Sebastian Schuberth <hidden>
Date
2016-06-15 23:07:39
Reply to
Richard Ipsum, 2016-06-15
On 10.11.2015 13:56, Richard Ipsum wrote:
quoted hunk ↗ jump to hunk
+Existing tools such as Github's pull-requests and Gerrit are already
+in wide use, why bother with something new?
+
+We are concerned that whilst git is a distributed version control
+system the systems used to store comments and reviews for content
+under version control are usually centralised,
I think it's a bit unjust to unconditionally mention Gerrit in this context as you seem to imply that Gerrit does not store *any* review data in Git.

Even without Dave's upcoming notedb, Gerrit already stores refs/changes in Git, and with the reviewnotes plugin [1] also the outcome of a review in refs/notes/review.

[1] https://gerrit.googlesource.com/plugins/reviewnotes/+/refs/heads/master/src/main/resources/Documentation/refs-notes-review.md

-- 
Sebastian Schuberth
Thread (13 messages) 13 messages, 7 authors, last reply 2016-06-15
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help