Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH v3 11/15] ref-filter: convert variable 'width' to an unsigned int

From: Karthik Nayak <hidden>
Date: 2016-06-15 23:07:38

On Wed, Jan 6, 2016 at 2:42 AM, Junio C Hamano [off-list ref] wrote:
Karthik Nayak [off-list ref] writes:
quoted
In align_atom_parser() the 'width' variable is an int, which requires
an explicit type conversion when used in strtoul_ui(). Hence make it
an unsigned int.

Helped-by: Eric Sunshine [off-list ref]
Signed-off-by: Karthik Nayak <redacted>
---
Shouldn't this be done in [09/15] from the beginning?  As it's not
like [09/15] was a pure code movement, this step looks like "Oops,
I screwed up earlier, and here is a fixup".

If we want to do this as a separate step, it would be easier to
follow if it is done _before_ 09/15 to the original of the code
movement, I think.
Haha, does seem that way. Will merge it in.

-- 
Regards,
Karthik Nayak
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help