Thread (2 messages) 2 messages, 2 authors, 2016-06-15

Re: [PATCH 1/2] push: Fully test --recurse-submodules on command line overrides config

flat view

From: Stefan Beller <hidden>
Date: 2016-06-15 23:07:29

On Wed, Dec 16, 2015 at 2:41 PM, Junio C Hamano [off-list ref] wrote:
Stefan Beller [off-list ref] writes:
quoted
On Thu, Dec 3, 2015 at 5:10 AM, Mike Crowe [off-list ref] wrote:
quoted
t5531 only checked that the push.recurseSubmodules config option was
overridden by passing --recurse-submodules=check on the command line.
Add new tests for overriding with --recurse-submodules=no,
--no-recurse-submodules and --recurse-submodules=push too.

Also correct minor typo in test commit message.

Signed-off-by: Mike Crowe <redacted>
This looks good to me.

Thanks,
Stefan
Thanks.  Does "This" refer to 1/2 alone or the whole series?
Yes. :)

"This" is applicable to both patches. We had the discussion on 2/2 about me
misreading a line a few days earlier, but apart from that it looked good, too.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help