Re: [PATCH v2 07/10] dir: free untracked cache when removing it
From: Junio C Hamano <hidden>
Date: 2016-06-15 23:07:28
Christian Couder [off-list ref] writes:
quoted hunk
Signed-off-by: Christian Couder <redacted> --- dir.c | 1 + 1 file changed, 1 insertion(+)diff --git a/dir.c b/dir.c index ffc0286..3b83cc0 100644 --- a/dir.c +++ b/dir.c@@ -1954,6 +1954,7 @@ void add_untracked_cache(void) void remove_untracked_cache(void) { + free_untracked_cache(the_index.untracked); the_index.untracked = NULL; the_index.cache_changed |= UNTRACKED_CHANGED; }
Up to this point the series makes sense (again, I am not saying the remainder does not ;-)). But shouldn't this step, as a bugfix, appear a lot earlier in the series?