Thread (18 messages) 18 messages, 3 authors, 2016-06-15

Re: [PATCH 2/8] xread: poll on non blocking fds

From: Stefan Beller <hidden>
Date: 2016-06-15 23:07:27

On Mon, Dec 14, 2015 at 2:58 PM, Eric Sunshine [off-list ref] wrote:
quoted
+                               /* We deliberately ignore the return value */
This comment tells us what the code itself already says, but not why
the value is being ignored. The reader still has to consult the commit
message to learn that detail, which makes the value of the comment
questionable.
It at least tells you it's not because of sloppiness. ;)
I'll elaborate that comment a bit further in a resend though.

Thanks,
Stefan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help