Jeff King [off-list ref] writes:
I don't think we want to pass down a "be strict" flag to the low-level
code filling in default_{name,email}. We might be strict in one call,
and non-strict in another within the same program. Worse, we actually
call ident_default_name() even when we don't actually want the name (we
could fix that, too, but it just adds more cases to the code).
So here's my solution, which instead carries the "is it bogus" flag
along with the default strings.
[1/3]: ident: make xgetpwuid_self() a static local helper
[2/3]: ident: keep a flag for bogus default_email
[3/3]: ident: loosen getpwuid error in non-strict mode
Thanks. Looks sensible.