Thread (2 messages) 2 messages, 2 authors, 2016-06-15

Re: [PATCH 2/2] push: Use "last one wins" convention for --recurse-submodules

flat view

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:07:25

Stefan Beller [off-list ref] writes:
quoted
+               git push --recurse-submodules=on-demand --no-recurse-submodules ../pub.git master &&
+               # Check that the submodule commit did not get there
Do we want to check here that the supermodule commit did get there,
instead of only checking the submodule?
Hmm, your point is that when the push succeeds, (1) the command
should return with 0 status, (2) the branch in the superproject
should update to the right commit, and (3) none of the submodule
should be affected, and the current test does not check the second
one?

I think that makes sense, in somewhat a paranoid way ;-).
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help