Re: [PATCH 3/2] git.c: make sure we do not leak GIT_* to alias scripts

On Mon, Dec 7, 2015 at 7:54 PM, Junio C Hamano [off-list ref] wrote:

Nguyễn Thái Ngọc Duy  [off-list ref] writes:

quoted

 Let's hope there will be no third report about this commit..

Hmm, why does this additional test fail only under prove but pass
without it?

It passes with prove for me. Some mysterious variable leaks through somehow?

quoted

+     env | grep GIT_ | sed "s/=.*//" | sort >actual

This is more about coding discipline than style, but piping grep
output to sed is wasteful.  "sed -ne '/^GIT_/s/=.*//p'" or something
like that, perhaps?

OK will fix.

I wondered what happens if the user has an unrelated stray variable
whose name happens to begin with GIT_ in her environment, but it
turns out that we cleanse them in test-lib.sh fairly early, so that
would be fine.  You need to tighten your "grep" pattern, though.

OK
-- 
Duy