Re: [PATCH 2/2] setup.c: re-fix d95138e (setup: set env $GIT_WORK_TREE when ..
From: Duy Nguyen <hidden>
Date: 2016-06-15 23:07:23
Possibly related (same subject, not in this thread)
- 2016-06-15 · Re: [PATCH 2/2] setup.c: re-fix d95138e (setup: set env $GIT_WORK_TREE when .. · Duy Nguyen <hidden>
- 2016-06-15 · Re: [PATCH 2/2] setup.c: re-fix d95138e (setup: set env $GIT_WORK_TREE when .. · Junio C Hamano <hidden>
- 2016-06-15 · Re: [PATCH 2/2] setup.c: re-fix d95138e (setup: set env $GIT_WORK_TREE when .. · Junio C Hamano <hidden>
On Thu, Dec 3, 2015 at 7:17 PM, Nguyễn Thái Ngọc Duy [off-list ref] wrote:
The solution in d95138e is reverted in this commit. Instead we reuse the solution from c056261 [4]. c056261 fixes another setup-messed-up-by-alias by saving and restoring env for git-clone and git-init. Now I conclude that setup-messed-by-alias is always evil. So the env restoration is done for _all_ commands whenever aliases are involved. It fixes what d95138e tries to fix. And it does not upset git-clone-inside-hooks.
(Reviewer hat on) I wrote env restoration is done for all commands, but the patch is actually about all _builtin_ commands. External ones do not receive this treatment. FIx is in the next reroll. -- Duy