Re: [PATCH v7 1/2] config.mak.uname: Darwin: define NO_GETTEXT for OS X 10.9 and later
From: Torsten Bögershausen <hidden>
Date: 2016-06-15 23:07:18
On 11/23/2015 09:25 AM, larsxschneider@gmail.com wrote:
quoted hunk ↗ jump to hunk
From: Lars Schneider <redacted> At least since OS X 10.9 Mavericks "libintl.h" is not available on OS X anymore. Disable the support with the NO_GETTEXT flag. Signed-off-by: Lars Schneider <redacted> --- config.mak.uname | 5 +++++ 1 file changed, 5 insertions(+)diff --git a/config.mak.uname b/config.mak.uname index f34dcaa..f3d98bb 100644 --- a/config.mak.uname +++ b/config.mak.uname@@ -102,9 +102,14 @@ ifeq ($(uname_S),Darwin) ifeq ($(shell expr "$(uname_R)" : '[15]\.'),2) NO_STRLCPY = YesPlease endif + # MacOS 10.7 Lion and higher ifeq ($(shell test "`expr "$(uname_R)" : '\([0-9][0-9]*\)\.'`" -ge 11 && echo 1),1) HAVE_GETDELIM = YesPlease endif + # MacOS 10.9 Mavericks and higher + ifeq ($(shell test "`expr "$(uname_R)" : '\([0-9][0-9]*\)\.'`" -ge 13 && echo 1),1) + NO_GETTEXT = YesPlease + endif NO_MEMMEM = YesPlease USE_ST_TIMESPEC = YesPlease HAVE_DEV_TTY = YesPlease
Unless I'm wrong, no Mac OS X had libintl.h, and the "unwritten agreement (?)" was that either a) libintl ist installed in some way (fink, mac ports, brew, other ways) or b) people use NO_GETTEXT=yes make Doesn't this patch close the door for b), making it impossible to build Git against libintl ? A better test may if libintl is installed may help, or better documentation.