Re: [PATCH v6 0/6] Add Travis CI support
From: Luke Diamand <hidden>
Date: 2016-06-15 23:07:17
On 20 November 2015 at 08:46, Lars Schneider [off-list ref] wrote:
On 19 Nov 2015, at 15:14, Jeff King [off-list ref] wrote:quoted
quoted
git-p4: retry kill/cleanup operations in tests with timeout git-p4: add p4d timeout in tests git-p4: add trap to kill p4d on test exitThese are all fairly gross, and I don't have p4d to test with myself. But if we assume they're all necessary, I suppose it's the best we can do.Unfortunately I think they are necessary. However, if someone finds a better way for stable p4d tests then I would be happy to see them go away, again.
I think that's just how p4d is I'm afraid. It doesn't like being stopped and started quickly (I guess it's not a normal use-case for most p4 users). I've made various unsuccessful attempts in the past to make these tests work reliably, and Lars' changes are far better than anything I ever managed. Luke