Re: [PATCH] http: fix some printf format warnings on 32-bit builds
From: Lars Schneider <hidden>
Date: 2016-06-15 23:07:14
On 13 Nov 2015, at 11:32, Torsten Bögershausen [off-list ref] wrote: On 2015-11-13 09.57, Eric Sunshine wrote:quoted
On Fri, Nov 13, 2015 at 3:46 AM, Lars Schneider [off-list ref] wrote:quoted
On 11 Nov 2015, at 18:49, Ramsay Jones [off-list ref] wrote:quoted
On 11/11/15 02:00, Stefan Beller wrote:quoted
On Tue, Nov 10, 2015 at 5:22 PM, Eric Sunshine [off-list ref] wrote:quoted
On Tue, Nov 10, 2015 at 7:23 PM, Ramsay Jones [off-list ref] wrote:quoted
Commit f8117f55 ("http: use off_t to store partial file size", 02-11-2015) changed the type of some variables from long to off_t. The 32-bit build, which enables the large filesystem interface (_FILE_OFFSET_BITS == 64), defines the off_t type as a 64-bit integer, whereas long is a 32-bit integer. This results in a couple of printf format warnings.My machine is 64-bit, though, so perhaps it's misleading to characterize this as a fix for 32-bit builds. In particular, off_t is 'long long' on this machine, so it complains about the "long" format specifier.I wonder if 32 bit compilation can be part of travis.Did this warning show up on the OS X build?Yes, I added CFLAGS="-Werror=format" to the my experimental TravisCI build and it breaks the build on OS X. See here (you need to scroll all the way down): https://travis-ci.org/larsxschneider/git/jobs/90899656 BTW: I tried to set "-Werror" but then I got a bunch of macro redefined errors like this: ./git-compat-util.h:614:9: error: 'strlcpy' macro redefined [-Werror] Is this a known issue? Is this an issue at all?Odd. I don't experience anything like that on my Mac.Could it be, that strlcpy is present on your system ? And where does it come from ? Which OS ? Which compiler ? What does `uname -r` say ? Do you have Macports, Fink, Brew... installed ?
Looks like this is a OS X only issue. Happens with clang and gcc on the OS X Mavericks TravisCI machines [1]: https://travis-ci.org/larsxschneider/git/jobs/90919078 https://travis-ci.org/larsxschneider/git/jobs/90919080 On Linux+gcc the following error happens if "-Werror" is present: https://travis-ci.org/larsxschneider/git/jobs/90919076 Do you have an idea what that might be? Linux+clang works fine: https://travis-ci.org/larsxschneider/git/jobs/90919074 - Lars [1] http://docs.travis-ci.com/user/ci-environment/