Re: [PATCH] checkout: refactor of --progress option

On Sat, Oct 31, 2015 at 10:57 AM, Edmundo Carmona Antoranz
[off-list ref] wrote:

+       /*
+        * Final processing of show_progress
+        * Any of these 3 conditions will make progress output be skipped:
+        * - selected --quiet
+        * - selected --no-progress
+        * - didn't select --progress and not working on a terminal
+        */
+       opts.show_progress = !opts.quiet && opts.show_progress &&
+                            (opts.show_progress > 0 || isatty(2));
+

I did a very small adjustment there from what I had sent yesterday.

It was (opts.show_progress >= 0 || isatty(2))

It was unnecessary to include the case of a 0 because it was discarded
by the second item on the outer short-circuited if:
opts_show_progress.

Let me know of your feedback and thanks.