Re: [PATCHv2 0/8] Expose the submodule parallelism to the user
From: Junio C Hamano <hidden>
Date: 2016-06-15 23:07:06
Stefan Beller [off-list ref] writes:
This replaces origin/sb/submodule-parallel-update (anchoring at 74367d8938, Merge branch 'sb/submodule-parallel-fetch' into sb/submodule-parallel-update) What does it do? --- This series should finish the on going efforts of parallelizing submodule network traffic. The patches contain tests for clone, fetch and submodule update to use the actual parallelism both via command line as well as a configured option. I decided to go with "submodule.jobs" for all three for now. What is new in v2? --- * The patches got reordered slightly * Documentation was adapted
A couple of things I noticed (other than "many issues pointed out in v1 have been updated") are: - The way 7/8 and 8/8 checks for uninitialized max_jobs are inconsistently written. The way 7/8 does, i.e. (max_jobs < 0), looks more conventional. - "Defaults to the `submodule.jobs` option" should say "configuration variable" instead. I haven't formed an opinion on 6/8 yet.