Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH v4 0/2] Fix interactive rebase when the editor saves with CR/LF

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:07:05

Johannes Schindelin [off-list ref] writes:
Turns out that we now check whether a single Carriage Return is a valid
command. This new check was introduced recently (1db168ee9, ironically
named "rebase-i: loosen over-eager check_bad_cmd check").
Will queue.

The root cause is not really "a new check added recently".  Earlier
the edited result was fed to stripspace and because "stripspace"
does what a dos-to-unix filter that turns CRLF into LF in addition
to cleaning up spaces and comments, we did not see the problematic
behaviour from "read" in this codepath.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help