Re: [PATCH 1/2 jk/war-on-sprintf] read_branches_file: plug a FILE* leak
From: Junio C Hamano <hidden>
Date: 2016-06-15 23:07:02
Johannes Sixt [off-list ref] writes:
The earlier rewrite f28e3ab2 (read_branches_file: simplify string handling) of read_branches_file() lost an fclose() call. Put it back. As on Windows files that are open cannot be removed, the leak manifests in a failure of 'git remote rename origin origin' when the remote's URL is specified in .git/branches/origin, because by the time that the command attempts to remove this file, it is still open. Signed-off-by: Johannes Sixt <redacted> ---
Thanks (and also for 2/2).
quoted hunk
remote.c | 1 + 1 file changed, 1 insertion(+)diff --git a/remote.c b/remote.c index 1101f82..fb16153 100644 --- a/remote.c +++ b/remote.c@@ -282,6 +282,7 @@ static void read_branches_file(struct remote *remote) return; strbuf_getline(&buf, f, '\n'); + fclose(f); strbuf_trim(&buf); if (!buf.len) { strbuf_release(&buf);