Thread (14 messages) flat view 14 messages, 5 authors, 2016-06-15

Re: [PATCH v3 1/3] Add Travis CI support

From: Sebastian Schuberth <hidden>
Date: 2016-06-15 23:06:49

On 10/11/2015 19:55, larsxschneider@gmail.com wrote:
+      sudo apt-get update -qq
+      sudo apt-get install -y apt-transport-https
+      sudo apt-get install perforce-server git-lfs
Why no "-y" also in this line, or append these to the previous line?

Or maybe even better, like [1] does, also use "--qq" (which implies 
"-y") for "apt-get install"?
+install: make configure && ./configure
+
+before_script: make
+
+script: make --quiet test
Semantically, it does not seem correct to me that configuarion goes to 
the install step. As "make test" will build git anyway, I'd instead 
propose to get rid of "install" and just say:

before_script: make configure && ./configure

script: make --quiet test

[1] https://github.com/git/git/pull/154/files

Regards,
Sebastian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help