Thread (5 messages) flat view 5 messages, 2 authors, 2016-06-15

Re: [PATCH v3 1/1] Makefile: make curl-config path configurable

From: Remi Pommarel <hidden>
Date: 2016-06-15 23:06:46

On Mon, Oct 05, 2015 at 01:49:09PM -0700, Jonathan Nieder wrote:
Remi Pommarel wrote:
quoted
Signed-off-by: Remi Pommarel <redacted>
For what it's worth, with or without the tweaks below,

Reviewed-by: Jonathan Nieder <redacted>
Thanks.
[...]
quoted
--- a/Makefile
+++ b/Makefile
@@ -39,6 +39,10 @@ all::
 # Define CURLDIR=/foo/bar if your curl header and library files are in
 # /foo/bar/include and /foo/bar/lib directories.
 #
+# Define CURL_CONFIG to curl's configuration program that gives informations
+# about the library (ie curl's version, cflags, ...) . If not set it defaults
+# to 'curl-config'.
Extra spaces, some wording tweaks:

s/gives informations about the library/prints information about the library/
s/(ie curl's version, cflags, .../) /(e.g., its version number)/
s/If not set it defaults to/The default is/
Do I need to resend a v4 patch with these modifications ? I am not sure
about the correct workflow here.

-- 
Rémi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help