Re: [PATCH v2 02/43] refs: make repack_without_refs and is_branch public
From: Michael Haggerty <hidden>
Date: 2016-06-15 23:06:45
On 09/29/2015 12:01 AM, David Turner wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Ronnie Sahlberg <redacted> Signed-off-by: David Turner <redacted> --- refs.c | 9 +-------- refs.h | 13 +++++++++++++ 2 files changed, 14 insertions(+), 8 deletions(-)diff --git a/refs.c b/refs.c index ce551e9..2741cc5 100644 --- a/refs.c +++ b/refs.c@@ -2826,14 +2826,7 @@ int pack_refs(unsigned int flags) return 0; } -/* - * Rewrite the packed-refs file, omitting any refs listed in - * 'refnames'. On error, leave packed-refs unchanged, write an error - * message to 'err', and return a nonzero value. - * - * The refs in 'refnames' needn't be sorted. `err` must not be NULL. - */ -static int repack_without_refs(struct string_list *refnames, struct strbuf *err) +int repack_without_refs(struct string_list *refnames, struct strbuf *err)
I looked for the corresponding change to remove `static` from is_branch(). Apparently that function already had external linkage, even though it was not listed in the header file. As a convenience to readers you might note that peculiarity in the commit message.
[...]
Michael -- Michael Haggerty mhagger@alum.mit.edu