Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] rebase: accept indented comments (fixes regression)

From: Matthieu Moy <hidden>
Date: 2016-06-15 23:06:44

Junio C Hamano [off-list ref] writes:
+		pick|p|drop|d|reword|r|edit|e|squash|s|fixup|f)
+			if ! check_commit_sha "${rest%% *}" "$lineno" "$1"
This does not pass my "tabs" test, as it parses the sha1 out of the line
assuming it's separated with a space. It's used in other places of the
code, but tabs still seem to work more or less by chance (they are not
parsed properly by transform_todo_ids, but then they are understood by
do_next).

I changed it to

	while read -r command sha1 rest

which is a bit more lazy.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help