Re: [PATCH v6b 5/8] branch: drop non-commit error reporting

Karthik Nayak [off-list ref] writes:

Remove the error "branch '%s' does not point at a commit" in
apppend_ref() which reports branch refs which do not point to
commits. Also remove the error "some refs could not be read" in
print_ref_list() which is triggered as a consequence of the first
error.

This seems to be the wrong codepath whose purpose is not to diagnose
and report a repository corruption. If we care about such a repository
corruption, we should report it from fsck instead.

(We actually already report it from fsck indeed)

This also helps in a smooth port of branch.c to use ref-filter APIs
over the following patches. On the other hand, ref-filter ignores refs
which do not point at commits silently.

Seems much better. Thanks,

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/