Re: [PATCH] Makefile: Change library order for static linking

Remi Pommarel [off-list ref] writes:

On Thu, Sep 17, 2015 at 12:51:18PM -0700, Junio C Hamano wrote:

quoted

IIRC historically the division between ssl and crypto was messy.
Especially, I am not sure if the change to NEEDS_SSL_WITH_CRYPTO
in this patch is correct for platforms that require that macro
defined.

I think it is correct as anywhere else in Makefile the order is ssl
first then crypto (from Makefile:1047):

IIRC, NEEDS_SSL_WITH_CRYPTO was invented for people whose platform
needed that to be different

597c9cc5 (Flatten tools/ directory to make build procedure simpler.,
2005-09-07) has this bit:

    +ifdef NEEDS_SSL_WITH_CRYPTO
    +       LIB_4_CRYPTO = -lcrypto -lssl
    +else
    +       LIB_4_CRYPTO = -lcrypto
    +endif

That is, for most people, linking with -lcrypto was sufficient, but
some people needed to grab things from -lssl when they need to do
so, because things in -lcrypto referred to what was only in -lssl.

Are you on such a platform?  If so can you test these both ways and
make sure you are not breaking things for those on such a platform?