Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [bug] .git/hooks/commit-msg.sample test is reversed

From: Matthieu Moy <hidden>
Date: 2016-06-15 23:06:33

Federico Fissore [off-list ref] writes:
Hello everyone

In file commit-msg.sample, grep test is reversed. It greps
'^Signed-off-by: '
while it should grep
'Signed-off-by: '

If you run the sample against attached file, it won't complain. Remove
the ^ and it will work as expected
I think the test is correct.

In grep, ^ can have two meanings:

'^foo' means "foo at the start of a line"
'[^abc]' means "one character but not a, b or c"

The Signed-off-by: trailer is meant to be at the start of a line, hence
the ^.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help