Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH v4 4/8] branch: move 'current' check down to the presentation layer

From: Matthieu Moy <hidden>
Date: 2016-06-15 23:06:31

Karthik Nayak [off-list ref] writes:
We check if given ref is the current branch in print_ref_list(). Move
this check to print_ref_item() where it is checked right before
printing.
You may want to add a sentence saying why this is good. Given the
context, it's relatively clear that this makes the code closer to the
shape expected by ref-filter, but if you imagine someone bisecting or
blaming and finding this commit in another context, that person may
appreciate more explanation.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help