Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH v17 05/14] ref-filter: introduce match_atom_name()

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:06:30

Matthieu Moy [off-list ref] writes:
OTOH, you are now accepting %(atom:) as a synonym to %(atom), and it's
not clear whether this is a deliberate decition.
I would say so.  When the caller wants to reject %(atom:), the
caller can tell it by checking val[0] == '\0' and reject that.

So it is better if you did not do this:
	if (!body[1]) {
		/* "atom_name:" */
		*val = NULL;
		return 1;
	}
which robs that information from the caller.  It should be
sufficient to just drop the check that allows "colorx" when
expecting "color" without making any other change, I would think.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help