Re: [PATCH v17 06/14] ref-filter: implement an `align` atom
From: Matthieu Moy <hidden>
Date: 2016-06-15 23:06:30
Karthik Nayak [off-list ref] writes:
+ /*
+ * TODO: Implement a function similar to strbuf_split_str()
+ * which would omit the separator from the end of each value.
+ */
+ s = to_free = strbuf_split_str(valp, ',', 0);
+
+ align->position = ALIGN_LEFT;
+
+ while (*s) {
+ if (s[1])A comment like /* strip trailing ',' */ here would really help the reader IMHO.
+ strbuf_setlen(s[0], s[0]->len - 1);
-- Matthieu Moy http://www-verimag.imag.fr/~moy/