Thread (1 message) 1 message, 1 author, 2016-06-15

Re: More builtin git-am issues..

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:06:27

Junio C Hamano [off-list ref] writes:
Johannes Sixt [off-list ref] writes:
quoted
Why do we need a new rule? The old git-am had a logic that pleased
everyone, and it must have been implemented somewhere. Shouldn't it be
sufficient to just re-implement or re-use that logic?
...
Perhaps we would need to tell has_conforming_footer() function who
the caller is, and use a different logic (i.e. "just re-implement")
when the caller is append_signoff().
Ah, I think I misunderstood you.  "just re-implement" could be "not
to use the existing helper used by other callers and instead do it
manually all inside builtin/am.c", and I agree that it would be the
safest way to go.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help