Re: [PATCH v1] t9821: use test_config

On 03 Sep 2015, at 15:04, Eric Sunshine [off-list ref] wrote:

On Thu, Sep 3, 2015 at 5:34 AM,  [off-list ref] wrote:

quoted

From: Lars Schneider <redacted>

Signed-off-by: Lars Schneider <redacted>
---

diff --git a/t/t9821-git-p4-path-variations.sh b/t/t9821-git-p4-path-variations.sh
index 81e46ac..5a26fec 100755
--- a/t/t9821-git-p4-path-variations.sh
+++ b/t/t9821-git-p4-path-variations.sh

@@ -45,7 +45,7 @@ test_expect_success 'Clone root' '
       (
               cd "$git" &&
               git init . &&
-               git config core.ignorecase false &&
+               test_config core.ignorecase false &&

test_config ensures that the config setting gets "unset" at the end of
the test, whether the test succeeds or not, so that subsequent tests
are not affected by the setting. However, in this case, since the $git
repository gets recreated from scratch for each test anyhow, use of
test_config is superfluous. In fact, it may be slightly
contraindicated since it could mislead the reader into thinking that
state is carried over from test to test. (Not a big objections, but
something to take into consideration.)

OK. Do I need to do anything to take the PATCH suggestion back?
I thanks for the explanation!

Cheers,
Lars