Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 3/3] am: rename "struct tree_desc t" to "desc" for readability

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:06:15

David Aguilar [off-list ref] writes:
Signed-off-by: David Aguilar <redacted>
---
 builtin/am.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Naming the tree_desc parameter given to unpack_trees() as "t" is
(unfortunately) an established convention, just like we often use
"i" and "j" in for() loop control.

Descriptive names are nicer, especially on the calling sites, but we
have quite a many hits from

    $ git grep unpack_trees\( \*.c

so perhaps do this as a clean-up patch after dust settles for all
the existing callers in archive, clone, commit, merge, read-tree,
reset, diff-lib, and merge-recursive?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help