Thread (4 messages) 4 messages, 3 authors, 2016-06-15

Re: [RFC/PATCH 07/11] branch: move 'current' check down to the presentation layer

From: Jacob Keller <hidden>
Date: 2016-06-15 23:05:56

On Tue, Jul 28, 2015 at 1:12 PM, Karthik Nayak [off-list ref] wrote:
On Tue, Jul 28, 2015 at 6:39 PM, Matthieu Moy
[off-list ref] wrote:
quoted
Karthik Nayak [off-list ref] writes:
quoted
We check if given ref is the current branch in print_ref_list().  Move
this check to print_ref_item() where it is checked right before
printing.
This means that the '*' and the different color are coded in C, hence
it's not possible to mimick this using "git for-each-ref --format ...".

I do not consider this as blocking, but I think the ultimate goal should
be to allow this, so that all the goodies of "git branch" can be made
available to other ref-listing commands.
Not sure what you mean here.
He means to make sure that any feature that was in tag, branch,
for-each-ref, etc should be available as part of ref-filter and in all
of them

Maybe he misunderstood code or maybe you misunderstood the comment here?

Regards,
Jake
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help