Re: [PATCH 2/2] refs: loosen restriction on wildcard "*" refspecs

On Thu, 2015-07-23 at 15:12 -0700, Junio C Hamano wrote:

Eric Sunshine [off-list ref] writes:

quoted

On Wed, Jul 22, 2015 at 5:05 PM, Jacob Keller <
jacob.e.keller@intel.com> wrote:

quoted

From: Jacob Keller <redacted>

Modify logic of check_refname_component and add a new disposition
regarding "*". Allow refspecs that contain a single "*" if
REFNAME_REFSPEC_PATTERN is set. Change the function to pass the 
flags as
a pointer, and clear REFNAME_REFSPEC_PATTERN after the first "*" 
so that
only a single "*" is accepted.

This loosens restrictions on refspecs by allowing patterns that 
have
a "*" within a component instead of only as the whole component. 
Also
remove the code that hangled refspec patterns in 
check_refname_format

s/hangled/handled/
...

Thanks; here is what I queued yesterday.

Woah. I bow to your imperative commit message abilities. The new commit
message is very nicely worded. Thanks for taking the time to reword my
jumble correctly.

Everything looked great to me.

Regards,
Jake