Re: [PATCH] Fix detection of uname failure
flat view
From: Johannes Schindelin <hidden>
Date: 2016-06-15 23:05:46
Hi Charles, On 2015-07-17 14:11, Charles Bailey wrote:
quoted hunk ↗ jump to hunk
diff --git a/dir.c b/dir.c index 8209f8b..52dbfd0 100644 --- a/dir.c +++ b/dir.c@@ -1848,7 +1848,7 @@ static const char *get_ident_string(void) if (sb.len) return sb.buf; - if (uname(&uts)) + if (uname(&uts) == -1)
From a quick `git grep '== -1'` and another quick `git grep '< 0'` it appears to me that we prefer the latter. Maybe you want to adjust it in the patch, too?
Ciao, Johannes