Re: [PATCH v2 05/10] ref-filter: add option to match literal pattern

On Sat, Jul 11, 2015 at 2:56 PM, Matthieu Moy
[off-list ref] wrote:

Karthik Nayak [off-list ref] writes:

quoted

On Fri, Jul 10, 2015 at 10:13 PM, Junio C Hamano [off-list ref] wrote:

quoted

Karthik Nayak [off-list ref] writes:

quoted

Since 'ref-filter' only has an option to match path names
add an option for regular pattern matching.

There is nothing "regular" about the pattern matching you are
adding.

Everywhere else we use patterns on refs we call wildmatch(), which
is an enhanced implementation of fnmatch(3), and you are doing the
same in this new codepath.

Just drop that word from here (and if you said something similar in
the documentation, drop "regular" ffrom there as well).  It would
invite confusion with regular expression matching, which we will not
do for refs.

Ok, will do. Thanks

Just dropping "regular" leads to a strange sentence, since the path name
match is also a kind of pattern-matching. I'd write

Since 'ref-filter' only has an option to match path names, add an option
for plain fnmatch pattern-matching.

Thanks for the heads up :)

-- 
Regards,
Karthik Nayak