Re: [PATCH v4 40/44] builtin-am: support and auto-detect mercurial patches

On Tue, Jun 30, 2015 at 4:32 AM, Stefan Beller [off-list ref] wrote:

On Mon, Jun 29, 2015 at 1:32 PM, Stefan Beller [off-list ref] wrote:

quoted

On Sun, Jun 28, 2015 at 7:06 AM, Paul Tan [off-list ref] wrote:

quoted

+                       tz = tz / (60 * 60) * 100 + tz % (60 * 60);

What happens if we have a negative input not matching a full hour, say -5400 ?
(would equate to 0130 in git)

for calculating the minutes we would only need to take % 3600 (which
you do), but
then we still need to divide by 60 to convert seconds to minutes?

That said, I wonder if we have some helper functions around somewhere as we
need to convert the timezone data at many places.

We convert timezone data at many places? Hmm, I thought all the time
related stuff was confined to date.c.

As far as I know from browsing around the source code, Git keeps the
timezone in the 24-hour format at all times, so there isn't a helper
function for converting from mercurial's "seconds" format to git's
24-hour format.

Thanks,
Paul