Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH v9 5/5] bisect: allow any terms set by user

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:05:33

Matthieu Moy [off-list ref] writes:
This is currently how it's implemented. You need to say

$ git bisect terms foo bar
$ git bisect start
Ahh, it means everything including the description (i.e. "you start
bisection") is consistent and perfectly fine.

I misread the patch, it seems.  Sorry for the noise.

Thanks.
And indeed "git bisect terms foo bar" errors out. I think the reason it
is this way is to allow

$ git bisect terms foo bar
$ git bisect start <sha1> <sha1>

But actually, we can allow "git bisect terms" until BISECT_TERMS is
created, which is your intuition and makes more sense IMHO. I'll try to
do that.
I am not sure if it is a good idea, though.  Matching the intuition
of those who (think they) know how it is implemented is much less
important than providing a behaviour that is simple to explain to
casual users.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help