Re: [PATCH] Add list-all-objects command

On Mon, Jun 22, 2015 at 02:50:10PM -0700, Junio C Hamano wrote:

quoted

We may want to take patch 1 separately for the maint-track, as it is
really a bug-fix (albeit one that I do not think actually affects anyone
in practice right now).

Hmph, add_unseen_recent_objects_to_traversal() is the only existing
user, and before d3038d22 (prune: keep objects reachable from recent
objects, 2014-10-15) added that function, for-each-packed-object
existed but had no callers.

I think that is because it was added by d3038d22^. :)

And the objects not beeing seen by that function (due to lack of
"open") would matter only for pruning purposes, which would mean
you have to be calling into the codepath when running a full repack,
so you would have opened all the packs that matter anyway (if you
have a "old cruft archive" pack that contains only objects that
are unreachable, you may not have opened that pack, though, and you
may prune the thing away prematurely).

Exactly, that matches my analysis.

So, I think I can agree that this would unlikely affect anybody in
practice.

Yep. I am OK if we do not even worry about it for "maint", then.

-Peff