Re: [PATCH v6 17/19] fsck: Introduce `git fsck --quick`

Hi Michael,

On 2015-06-21 06:55, Michael Haggerty wrote:

On 06/19/2015 10:53 PM, Junio C Hamano wrote:

quoted

Johannes Schindelin [off-list ref] writes:

quoted

Can you think of a name for the option that is as short as `--quick`
but means the same as `--connectivity-only`?

No I can't.  I think `--connectivity-only` is a very good name that
is unfortunately a mouthful, I agree that we need a name that is as
short as `--xxxxx` that means the same as `--connectivity-only`.  I
do not think `--quick` is that word; it does not mean such a thing.

`--connectivity-only` says that "of all the things that fsck can do,
skip everything except for the connectivity check". But the switch
really affects not the connectivity part of the checks (that part is
done in either case), but the blob part.

Right, so `--skip-blobs` would be a better name, I guess, if you follow Junio's reasoning.

But...

[...]
As for thinking of a shorter name for the option: assuming the blob
integrity checks can be turned on and off independently as described
above, then I think it is reasonable to *also* add a `--quick` option
defined as

--quick: Skip some expensive checks, dramatically reducing the
    runtime of `git fsck`. Currently this is equivalent to
    `--no-check-blob-integrity`.

This was my idea, without bothering to introduce the `--no-check-blob-integrity`. I was really thinking along the lines: If you just want to check quickly whether your repository is in good shape, without wanting to check too deeply, then `--quick` is your friend. I just *happened* to think of skipping blobs as a way to trade off accuracy for speed, but really, the reason why I introduced `--quick` was to have a way to check much faster if somewhat less thoroughly.

Ciao,
Dscho