Thread (3 messages) flat view 3 messages, 2 authors, 2016-06-15

Re: [PATCH] format-patch: introduce format.outputDirectory configuration

From: Alexander Kuleshov <hidden>
Date: 2016-06-15 23:05:24

Hello,

Yes, thank you for advice.

2015-06-19 17:34 GMT+06:00 Remi Galan Alfonso
[off-list ref]:
Alexander Kuleshov [off-list ref] writes:
quoted
+test_expect_success "format-patch format.outputDirectory option" '
+ git config format.outputDirectory "patches/" &&
+ git format-patch master..side &&
+ cnt=$(ls | wc -l) &&
+ echo $cnt &&
+ test $cnt = 3 &&
+ git config --unset format.outputDirectory
+'
You should probably do:
quoted
+ test_config format.outputDirectory "patches/" &&
instead of:
quoted
+ git config format.outputDirectory "patches/" &&
[...]
+ git config --unset format.outputDirectory
This way there shouldn't be any problem with the
tests following yours if your test fails in the middle.

Rémi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help