Re: [PATCH v2] upload-pack: Fail if cloning empty namespace

Johannes Löthberg [off-list ref] writes:

On 13/06, Johannes Löthberg wrote:

quoted

Git should fail to clone if trying to clone from an non-existing
ref namespace, since it's the same as a non-existing repository

Signed-off-by: Johannes Löthberg <redacted>
---

Changes since v1:

* Fixed the namespace check, since I apparently forgot to check with a
 bare repo in my last test. D'oh.

Two other options for this would be to either add a
get_git_namespace_len() function and use that, or a is_namespaced()
functon. But since it's only used here for now at least it feels simpler
to not bloat the codabase with another function which has no other use.

I should note that I have a small test script written now, ready to be
converted into a git test, though I want some opinions on whether the
patch would be merged before bothering to convert it.

You would probably want new tests, but more importantly did you make
sure this passes existing tests?  It seems to break 5509 (there
could be others) at least for me.